Add mod_ssl-like Placeholder Support for Server and Client Certificates in Caddy#6780
Closed
Ko496-glitch wants to merge 4 commits intocaddyserver:masterfrom
Closed
Add mod_ssl-like Placeholder Support for Server and Client Certificates in Caddy#6780Ko496-glitch wants to merge 4 commits intocaddyserver:masterfrom
Ko496-glitch wants to merge 4 commits intocaddyserver:masterfrom
Conversation
…luding mod_ssl-like behavior
mohammed90
requested changes
Jan 9, 2025
…lient certificates
Ko496-glitch
commented
Jan 9, 2025
Author
Ko496-glitch
left a comment
There was a problem hiding this comment.
Updated the lowercase placeholder and comments on the change.
Author
|
@mohammed90 just checking in too see if everything for the PR looks good ? |
Member
At first glance, it looks fine, but I haven't had the time to review it thoroughly. We'll get to it. |
Author
Member
Thanks for the effort; I think I'll close this for now because it's been a year and would need to be significantly revised anyway. Feel free to make a new PR if you'd like to address it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces functionality similar to Apache's mod_ssl by adding support for dynamic placeholders for server and client certificates in Caddy. The implementation addresses the following:
1)Dynamic Placeholder Population:
Populates placeholders for both server and client certificates during TLS connections, enabling detailed certificate information to be accessed in configurations (e.g., headers, logs).
2)Support for Default Values:
Ensures placeholders return meaningful default values (e.g., null or descriptive strings) when client certificates are not provided (e.g., in non-mTLS scenarios).
3)Centralized Logic:
Introduced a new function, handleMTLSEnabledWithExport, to handle placeholder population efficiently, reducing redundancy and improving maintainability.