Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WithLazy to prevent eager serialization of the event data #6671

Merged

Conversation

ankon
Copy link
Contributor

@ankon ankon commented Nov 1, 2024

Found while load testing: Even with the "events" app not logging out on "DEBUG" it would still go through the pain of serializing the event data. Especially for tls_get_certificate that is painful.

Comparison before/after:
image
image

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thank you!

@mholt mholt added this to the v2.9.0-beta.3 milestone Nov 1, 2024
@mholt mholt merged commit 1d15652 into caddyserver:master Nov 1, 2024
33 checks passed
@mholt mholt added the optimization 📉 Performance or cost improvements label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization 📉 Performance or cost improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants