Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverseproxy: Change logs for write errors to warn level #6532

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jum
Copy link
Contributor

@jum jum commented Aug 21, 2024

Most of the errors that can be seen here are write errors due to clients aborting the request from their side. Often seen ones include:

* writing: ... write: broken pipe
* writing: ... connection timed out
* writing: http2: stream closed
* writing: timeout...
* writing: h3 error...

Most of these errors are beyond of the control of caddy on the client side, probably nothing can be done on the server side. It still warrants researching when these errors occur very often, so a change in level from error to warn is better here to not polute the logs with errors in the normal case.

Most of the errors that can be seen here are write errors due to clients
aborting the request from their side. Often seen ones include:

	* writing: ... write: broken pipe
	* writing: ... connection timed out
	* writing: http2: stream closed
	* writing: timeout...
	* writing: h3 error...

Most of these errors are beyond of the control of caddy on the client side,
probably nothing can be done on the server side. It still warrants
researching when these errors occur very often, so a change in level from
error to warn is better here to not polute the logs with errors in the
normal case.
@francislavoie
Copy link
Member

Yeah that makes sense I think. Most are not actionable errors.

@francislavoie francislavoie changed the title Change errors writing the response to warning. reverseproxy: Change logs for write errors to warn level Aug 21, 2024
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's a good point. LGTM. Thanks!

@mholt mholt merged commit 2bb2ecc into caddyserver:master Aug 21, 2024
23 checks passed
@jum jum deleted the warning_write branch August 22, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants