-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging: Customizable zapcore.Core
#6381
Conversation
Thanks for the contribution! Since we're teeing, I wonder if multiple cores (a slice of cores) would be worthwhile? Maybe not. Just thinking. If not, this looks pretty good and we can probably merge it after a quick review. (I think godoc comments will be needed) |
I think an output module is still always needed, right? So I guess you'd want to use This also needs Caddyfile support I think, and it would be nice if we could have somekind of mock core module that we can use for testing configuration etc. |
zapcore.Core
Thanks for the feedback, addressing comments . @mholt An implementation of this interface could chain up multiple cores if needed. I can add the doc strings. @francislavoie It uses the default logging core. If the user doesn't want additional output |
39bd590
to
50fa1a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM now :) Thank you!
This change enables support custom
caddy.logging.cores
that implementzapcore.Core
for a sentry event reporting plugin that reports errors and their traces at github.com/kkroo/caddy-sentry