Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: encode: use FlushError instead of Flush #6168

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

WeidiDeng
Copy link
Member

No description provided.

Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, should work fine as long as plugins use response controller, right?

modules/caddyhttp/encode/encode.go Outdated Show resolved Hide resolved
WeidiDeng and others added 2 commits March 11, 2024 10:16
@francislavoie francislavoie added the bug 🐞 Something isn't working label Mar 11, 2024
@francislavoie francislavoie added this to the v2.8.0 milestone Mar 11, 2024
@francislavoie francislavoie merged commit 1bd598e into master Mar 11, 2024
25 checks passed
@francislavoie francislavoie deleted the encode-flush-error branch March 11, 2024 03:04
@mholt
Copy link
Member

mholt commented Mar 11, 2024

Thank you for the recent patches, Weidi!

This won't break anyone relying on a Flusher will it?

dev-polymer pushed a commit to dev-polymer/caddy that referenced this pull request Mar 13, 2024
mholt pushed a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants