encode: Compress more media types by default #6081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
approved these changes
Feb 5, 2024
mholt
reviewed
Feb 5, 2024
francislavoie
changed the title
steffenbusch
reviewed
Feb 5, 2024
dunglas
force-pushed
the
fix/encode-match
branch
from
d810adf to
2348ac8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all media types supported by Cloudflare to the default list of compressed media types.
This fixes a problem reported by @pborreli: by default JSON-LD responses generated by API Platform aren't compressed.
I've kept Atom, which isn't supported by Cloudflare but is in our existing list (other existing values are also in Cloudflare's list).
I've kept the strategy of adding a wildcard at the end of each of the values (to allow all parameters, I suppose), but this may be too permissive. If we keep the wildcards, I wonder if building a regex wouldn't be faster than the current iteration. I'll try this and open another PR in the next few weeks if it improves performance.