Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Only test cross-build on latest Go version #4319

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Conversation

francislavoie
Copy link
Member

This generated way too many test jobs, which weren't really that useful. Cross-build is just to keep us posted on which architectures are building okay, so it's not necessary to do it twice. Only plan9 is not working at this point (see #3615)

This generated way too many test jobs, which weren't really that useful. Cross-build is just to keep us posted on which architectures are building okay, so it's not necessary to do it twice. Only plan9 is not working at this point (see #3615)
@francislavoie francislavoie added the CI/CD 🔩 Automated tests, releases label Aug 31, 2021
@francislavoie francislavoie added this to the v2.4.5 milestone Aug 31, 2021
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you, haha. (Is there a shortcut for "latest Go version"?)

@francislavoie
Copy link
Member Author

francislavoie commented Aug 31, 2021

There is, but I rather explicitly update everything at the same time (including go.mod etc). I don't want random CI failures from using latest when the latest Go version is released while requiring some minor changes for us to support (e.g. quic-go usually needs to explicitly support new versions due to the crypto/tls forking)

Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so much lighter. Thanks, Francis!

@mholt mholt merged commit 105dac8 into master Aug 31, 2021
@mholt mholt deleted the less-cross-build-noise branch August 31, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD 🔩 Automated tests, releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants