-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reverseproxy: Implement health_uri, replaces health_path, supports query #4050
Conversation
Flaky tests 😢 |
So here's a curveball, what if we introduce |
Sure, that works 👍 I'll rework it |
ba66223
to
85d5e58
Compare
@mholt Done 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Also fixes a bug with `health_status` Caddyfile parsing , it would always only take the first character of the status code even if it didn't end with "xx".
85d5e58
to
786c813
Compare
786c813
to
9b9dec7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for helping with this! This is a nice improvement.
Closes #4049
Also fixes a bug with
health_status
Caddyfile parsing, it would always only take the first character of the status code even if it didn't end with "xx". I fixed the same bug in #4021 but it's relevant here too because it affects the adapt test I wrote (will rebase #4021 after and remove the redundant fix)