httpcaddyfile: Add error directive for the existing handler
#4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilbee101920
approved these changes
Feb 26, 2021
mholt
previously approved these changes
Mar 2, 2021
mholt
approved these changes
Mar 12, 2021
|
This was one of the things keeping me on an older version of Caddy, so thank you for this. |
|
@habibalamin which version? This isn't something that existed in a previous version. |
|
Sorry, I was a bit unclear. There was a “rewrite hack” for the exact use case in the linked issue that you could do in v1 but not v2, and adding this directive gets me one step closer to letting me migrate to v2, i.e. this isn't something that existed in an older version, but it was something you could mimic with a workaround that's no longer allowed in v2 (which cleaned things up). |
mholt
pushed a commit
to caddyserver/website
that referenced
this pull request
Apr 16, 2021
Docs for the new directive in caddyserver/caddy#4034. Also adding a bit in `handle_errors` mentioning that `reverse_proxy` doesn't trigger errors when a response has an "error" HTTP status; not sure how to word this clearly, cause `reverse_proxy` still can trigger errors if there's no upstream or whatever. We should probably add examples for that later, and augment this paragraph to mention `handle_response` once that's merged (caddyserver/caddy#4021)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3782
Just adds Caddyfile support for the static
errorhandler that already exists: https://caddyserver.com/docs/json/apps/http/servers/routes/handle/error/Syntax: