Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddytls: Add dns config to acmeissuer #3701

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

francislavoie
Copy link
Member

The dns option was missing, so this would fail with an error:

    tls {
        dns cloudflare XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
        issuer acme {
            dir https://acme-staging-v02.api.letsencrypt.org/directory
            resolvers 1.0.0.1
        }
    }
Error during parsing: when defining an issuer, all its config must be in its block, rather than from separate tls subdirectives

The fix is to add dns to acmeissuer as well, so this is possible:

    tls {
        issuer acme {
            dir https://acme-staging-v02.api.letsencrypt.org/directory
            dns cloudflare XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
            resolvers 1.0.0.1
        }
    }

@francislavoie francislavoie requested a review from mholt September 1, 2020 22:32
@francislavoie francislavoie added the bug 🐞 Something isn't working label Sep 1, 2020
@francislavoie francislavoie added this to the v2.2.0 milestone Sep 1, 2020
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye, that ought to do it. Can't believe I forgot about that one 😅 Thanks!

@mholt mholt merged commit 00e6b77 into caddyserver:master Sep 8, 2020
@francislavoie francislavoie deleted the acmeissuer-dns branch September 8, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants