Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Include tracking of GOOS for which Caddy fails to build #3617

Merged
merged 10 commits into from
Aug 1, 2020

Conversation

mohammed90
Copy link
Member

We learned about the build failure for Solaris by accident. Perhaps it's better we have track of which OSs Caddy fails to build for to have an understanding our areas of improvements and where we are probably unable to support.

Updates #3615

@mohammed90 mohammed90 requested a review from francislavoie July 29, 2020 00:07
@mohammed90 mohammed90 force-pushed the cross-build-check branch 8 times, most recently from 4254c5f to 2a70844 Compare July 29, 2020 00:57
@mohammed90 mohammed90 added the do not merge ⛔ Not ready yet! label Jul 29, 2020
@mohammed90 mohammed90 removed the do not merge ⛔ Not ready yet! label Jul 29, 2020
Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll dig deeper later but at a glance:

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/cross-build.yml Outdated Show resolved Hide resolved
@francislavoie
Copy link
Member

FYI @mholt unfortunately github actions doesn't have a "warning" state for jobs yet, but there's an open issue discussing it here actions/runner#2347

So for now, we have continue-on-error: true set for this stuff so that it doesn't make the PR go red for any cross-build failures, but the only other option is green. To see the failures you can look at the annotations on the workflow: https://github.com/caddyserver/caddy/actions/runs/187524216

@mholt
Copy link
Member

mholt commented Jul 31, 2020

This looks cool, neat idea!

I can see why this would be even better with some sort of "warning" result instead of just green/red.

I guess something we can add to our TODO list is to submit patches upstream, or at least request that they make their build tags more correct, so that we can continue to build x-platform.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready to merge or should we wait? Is it even useful if it always emits a green status?

@mohammed90
Copy link
Member Author

Is this ready to merge or should we wait? Is it even useful if it always emits a green status?

It is ready. The results always being green bothers me too, but I hope the workflow being listed reminds to check for annotations... until Github Actions supports tri-state results.

@mohammed90
Copy link
Member Author

Blocked by #3625 😓 (kinda, sorta)

@mholt
Copy link
Member

mholt commented Jul 31, 2020

My bad. Will get that figured out soon.

@mholt
Copy link
Member

mholt commented Aug 1, 2020

Okie all fixed

@mohammed90 mohammed90 merged commit 399eff4 into master Aug 1, 2020
@mohammed90 mohammed90 deleted the cross-build-check branch August 1, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants