Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: Update build instructions #2565

Merged
merged 1 commit into from
Apr 12, 2019
Merged

readme: Update build instructions #2565

merged 1 commit into from
Apr 12, 2019

Conversation

elcore
Copy link
Collaborator

@elcore elcore commented Apr 12, 2019

1. What does this change do, exactly?

Update the build instructions to reflect the transition to Go modules. This will not be necessary in Go 1.13, according to https://blog.golang.org/modules2019

2. Please link to the relevant issues.

#2560

3. Which documentation changes (if any) need to be made because of this PR?

n/a

4. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments explaining package types, values, functions, and non-obvious lines of code
  • I am willing to help maintain this change if there are issues with it later

@mholt The PR template does not show up :/

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for thinking of this!

@mholt mholt merged commit 605787f into master Apr 12, 2019
@mholt mholt deleted the build-go-readme branch April 12, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants