Skip to content

Commit

Permalink
fastcgi: Remove obsolete TODO
Browse files Browse the repository at this point in the history
We already have d.Err("transport already specified") in the reverse_proxy parsing code which covers this case
  • Loading branch information
francislavoie committed Apr 29, 2021
1 parent 0aba875 commit a7bb7a0
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions modules/caddyhttp/reverseproxy/fastcgi/caddyfile.go
Original file line number Diff line number Diff line change
Expand Up @@ -353,8 +353,6 @@ func parsePHPFastCGI(h httpcaddyfile.Helper) ([]httpcaddyfile.ConfigValue, error

// the rest of the config is specified by the user
// using the reverse_proxy directive syntax
// TODO: this can overwrite our fcgiTransport that we encoded and
// set on the rpHandler... even with a non-fastcgi transport!
err = rpHandler.ParseCaddyfileReverseProxy(h.WithDispenser(dispenser))
if err != nil {
return nil, err
Expand Down

0 comments on commit a7bb7a0

Please sign in to comment.