Allow domain overrides for challenge delegation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more information, see libdns/duckdns#1 This commit adds Caddyfile parsing for an `override_domain` directive.
|
While you're at it, could you set the markdown code block language in the README to |
|
Done; changed that and fixed up a lingering |
|
Could you add a quick section above Also please add the new option to the example JSON config as well. |
|
Yep, something like that? |
francislavoie
approved these changes
Dec 29, 2020
francislavoie
requested changes
Dec 29, 2020
Co-authored-by: Francis Lavoie <[email protected]>
francislavoie
requested changes
Dec 29, 2020
Co-authored-by: Francis Lavoie <[email protected]>
|
Done. I can rebase this all down to 1 commit if you prefer too, just let me know. |
No worry, I tend to squash merge. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information, see libdns/duckdns#1
This commit adds Caddyfile parsing for an
override_domaindirective.
Should be pretty straightforward -- this adds
override_domainin the same manner asapi_tokenwas being parsed. I did not add it as an argument to the main directive as I don't think it'll be as commonly used.I also changed the parsing for
api_token-- unless I missed something, I think this wasn't working. ThatNextArgcall has to happen to get the parser to move on fromapi_tokento the provided value.Currently writing up a description of this in the README; I'll un-mark draft status once I have that up.