-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minio client and extra initialization options #716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I'd ask you to add an example/minio/
and example/minio/.test.sh
to test the basics here as this service is getting more complex and it's good to have regression tests.
fffc6bc
to
aa3bda0
Compare
You can test it like:
|
aa3bda0
to
6c9ed60
Compare
Looks like |
It looks like minio doesn't actually generate credentials when left empty, it just uses |
057d2b8
to
ce46629
Compare
I've pushed a fix for making |
fea2ae8
to
bc9790c
Compare
bc9790c
to
8abde84
Compare
Failure was because of I now use |
This adds
mc
to the profile if minio is enabled, and configures it to connect to the local minio using the conventionallocal
alias.I added
services.minio.clientConfig = null
as an opt-out. I imagine configuring other endpoints via Nix isn't ideal, because the config contains credentials, so this provides a way out to using your regular user config.I also added a
after
option to allow running some additional initialization following minio startup.