go: use non-versioned buildGoModule to support out-of-band compilers
#1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you set `languages.go.package` to a version of the go compiler that doesn't yet exist in the `nixpkgs` input, you'll get an evaluation error on `buildGoXXXModule` because the function for that specific version doesn't exist. I couldn't find anything in the docs preventing us from using the base `buildGoModule` and override the `go` argument as we already do.
Deploying devenv with
|
| Latest commit: |
f7ab477
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3a13056a.devenv.pages.dev |
| Branch Preview URL: | https://fix-go-builder-override.devenv.pages.dev |
|
This works. The bigger issue is that older tools fail to compile with newer versions of go. That makes updating just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set
languages.go.packageto a version of the go compiler that doesn't yet exist in thenixpkgsinput, you'll get an evaluation error onbuildGoXXXModulebecause the function for that specific version doesn't exist.I couldn't find anything in the docs preventing us from using the base
buildGoModuleand override thegoargument as we already do.Fixes #1568.