devenv: escape shell vars in task exports #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sourcing exported variables with spaces in them. Hello, macOS.
Deploying devenv with
|
| Latest commit: |
f2e17c6
|
| Status: | 🚫 Build failed. |
domenkozar
reviewed
Sep 26, 2024
| @@ -836,6 +840,21 @@ impl TasksUi { | |||
| } | |||
| } | |||
|
|
|||
| /// Escape a shell variable by wrapping it in single quotes. | |||
| /// Any single quotes within the variable are escaped. | |||
| fn shell_escape(s: &str) -> String { | |||
There was a problem hiding this comment.
I wonder if we should instead use some library like https://docs.rs/shell-quote/latest/shell_quote/ not to maintain this code which is tricky to get right
There was a problem hiding this comment.
Yeah, maybe. The above is what nix develop does, which felt like a safe choice without getting into the weeds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sourcing exported variables with spaces in them. Hello, macOS.