New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services): make "postgres" process the top-level process within process-compose #1437

Merged

domenkozar merged 1 commit into cachix:main from thenonameguy:feat/pc-postgres-exec

Sep 11, 2024

Contributor

thenonameguy commented Sep 11, 2024 •

edited

Loading

process-compose has functionality to show open ports of the processes it manages:

https://github.com/F1bonacc1/process-compose/blob/2540374e305b0ac683ad88e06c637fe2fa7c0e5c/src/app/process.go#L736-L751

This doesn't work if the networked process is the child of the implicit bash used by process-compose.

By prepending exec we replace the implicit bash script with the start-postgres script, which calls exec postgres internally.

This pattern should be enforced across the modules.


          Make "postgres" process the top-level process

4b31c79

process-compose has functionality to show open ports
of the processes it manages:

https://github.com/F1bonacc1/process-compose/blob/2540374e305b0ac683ad88e06c637fe2fa7c0e5c/src/app/process.go#L736-L751

This doesn't work if the networked process is the child of the implicit `bash`
used by process-compose.

By running prepending `exec` we replace the implicit bash script
with the start-postgres script, which calls `exec postgres` internally.

This pattern should be enforced across the modules.

domenkozar merged commit 39bf6ce into cachix:main

254 of 263 checks passed

thenonameguy deleted the feat/pc-postgres-exec branch

September 13, 2024 11:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet