fix: redis should listen on unix socket when port is 0 #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Can you move the test into tests? |
|
I have moved it and |
domenkozar
reviewed
Aug 11, 2024
src/modules/services/redis.nix
Outdated
| @@ -67,14 +74,15 @@ in | |||
| cfg.package | |||
| ]; | |||
|
|
|||
| env.REDIS_UNIX_SOCKET = REDIS_UNIX_SOCKET; | |||
There was a problem hiding this comment.
I wonder if we should set this on non-zero port?
There was a problem hiding this comment.
Yeah, you're right. It is only needed when port is zero.
I don't know what the right way to conditionally set an environment variable would be, would this work.
env.REDIS_UNIX_SOCKET = if cfg.port == 0 then REDIS_UNIX_SOCKET else null;There was a problem hiding this comment.
I went with optionalAttrs instead of setting it to null.
|
I don't think the failing tests are related to my changes, am i wrong? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1068
This PR configures the redis service to listen on a unix socket when the specified port is 0. The socket file will be stored in
DEVENV_RUNTIME. A new environment variableREDIS_UNIX_SOCKETwill also be injected into the environment. It points to the socket file, so that users can easily connect to to the service like this.redis-cli -s $REDIS_UNIX_SOCKETdevenvis the main tool that got me introduced to the nix world, it is a really useful tool, thanks for making it.