Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove darwinFlags in rust module #1356

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

tianyaochou
Copy link
Contributor

@tianyaochou tianyaochou commented Jul 31, 2024

Remove darwinFlags to fix linking error when compiling no_std crate. Closing #1355

Only tested with Developer Frameworks already installed in the system.

I am not sure if this change will break those who only rely on Developer Frameworks in Nixpkgs and don't have Developer Frameworks installed outside Nix.

Copy link
Member

@sandydoo sandydoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated our rust tests and examples to work with this change.

@sandydoo sandydoo added the macos Affects systems running macOS label Aug 1, 2024
@domenkozar
Copy link
Member

What if you need to compile against a framework library on macos?

@sandydoo
Copy link
Member

sandydoo commented Aug 3, 2024

@domenkozar, I tested this out in a fresh VM.
Nix already adds the -iframework CFLAG for us.
The -L framework rust flag doesn't seem necessary. I tested a bunch of random OSS projects that link to frameworks — they compile without issues. Is this around from the pre-1.0 era when we didn't have setup hooks?

@domenkozar domenkozar merged commit 2f53cdc into cachix:main Aug 5, 2024
267 of 275 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macos Affects systems running macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants