fix: --upgrade-dep not available with python < 3.9 #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenkozar
requested changes
Jun 28, 2024
k3yss
force-pushed
the
work/keys/python-fix
branch
2 times, most recently
from
7640e59
to
50ad838
Compare
k3yss
force-pushed
the
work/keys/python-fix
branch
from
50ad838
to
02df1c8
Compare
|
Should be fine now @domenkozar |
|
fixing tests |
domenkozar
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--upgrade-depflag was introduced in python version3.9, this PR disables the flag in case of python version lower than the version3.9fixes #1289