Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign PGHOST to runtimeDir as default #1298

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Assign PGHOST to runtimeDir as default #1298

merged 3 commits into from
Jul 4, 2024

Conversation

k3yss
Copy link
Collaborator

@k3yss k3yss commented Jun 24, 2024

Fixes #1253

@k3yss k3yss mentioned this pull request Jun 24, 2024
Closed
@domenkozar
Copy link
Member

I'm not sure this is correct, because * means all IP addresses, but it's not setting up the socket in runtimeDir.

@sandydoo
Copy link
Member

If * binds to all interfaces, then could we use localhost or 127.0.0.1 in that case?

@domenkozar
Copy link
Member

Let's have a test for this

@k3yss k3yss changed the title fix: Assign PGHOST to runtimeDir when listen_address is set to * Assign PGHOST to runtimeDir as default Jun 26, 2024
@k3yss k3yss mentioned this pull request Jun 28, 2024
Merged
@domenkozar domenkozar merged commit 2e6c99c into cachix:main Jul 4, 2024
268 of 275 checks passed
@k3yss k3yss deleted the work/keys/postgres-fix branch July 4, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandydoo sandydoo sandydoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting postgres listen_addresses to * also sets $PGHOST to *
3 participants
@k3yss @domenkozar @sandydoo