devenv: split out library #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying devenv with
|
| Latest commit: |
d7fec54
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6695626a.devenv.pages.dev |
| Branch Preview URL: | https://split-lib.devenv.pages.dev |
sandydoo
commented
Jun 10, 2024
|
I'm going to merge #1194 next and make 1.0.6, then this can go in ASAP :) |
|
Ready for rebase! |
sandydoo
force-pushed
the
split-lib
branch
4 times, most recently
from
e14f29e
to
6800949
Compare
sandydoo
commented
Jun 13, 2024
| @@ -23,5 +23,7 @@ pkgs.rustPlatform.buildRustPackage { | |||
|
|
|||
| postInstall = '' | |||
| wrapProgram $out/bin/devenv --set DEVENV_NIX ${inputs.nix.packages.${pkgs.stdenv.system}.nix} --prefix PATH ":" "$out/bin:${inputs.cachix.packages.${pkgs.stdenv.system}.cachix}/bin" | |||
| # TODO: problematic for our library... | |||
There was a problem hiding this comment.
We could use env! to embed a default path to nix in the library. That would remove the runtime requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.