Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: unsuccessful push should scream "error!" instead of failing silently #153

Open
bryango opened this issue Aug 12, 2023 · 2 comments
Open

Comments

@bryango
Copy link

bryango commented Aug 12, 2023

Version: @v12

I forget to configure the secret key for one of my repo's action (my bad), but cachix push simply fails silently without warning. One has to dig into the log to find that:

Post job cleanup.
Cachix: push
  Pushing is disabled as signingKey nor authToken are set (or are empty?) in your YAML file.

I believe that the push action should scream "error!" and fail if it's unsuccessful. It's much easier to debug!

@domenkozar
Copy link
Member

It's tricky, because most of the time this is intended, for example in pull requests where the user doesn't have access to the secrets.

We could however check if user has write access and make it an error/warning then.

@bryango
Copy link
Author

bryango commented Oct 3, 2023

It's tricky, because most of the time this is intended, for example in pull requests where the user doesn't have access to the secrets.

I see, that's a reasonable use case.

We could however check if user has write access and make it an error/warning then.

That's a good idea! Or maybe, one can indicate a cachix push failure without failing the whole jobset? I'm not sure whether this is possible with GitHub actions.

roberth added a commit to NixOS/nix that referenced this issue Jun 30, 2024
Maybe it prints something, as a workaround for cachix/cachix-action#153,
which might explain our flaky installer_test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants