Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New line / Markdown not maintained in incidents and maintenance #2935

Closed
labolanimichele opened this issue Mar 13, 2018 · 9 comments
Closed
Assignees
Labels
Bug Bugs with Cachet Good First Issue If you're looking for a good issue to PR, start here
Milestone

Comments

@labolanimichele
Copy link

Hello,

sorry to reopen this one, but on the latest pull of 2.4 it still does not work for me (pulled today).

Please see attached the template, what is shown in the status page (which is perfect) and what I receive by email (which is not working for me).

Any hint? It may be something trivial I cannot see...
This is currently the only thing which is preventing us from using Cachet for our customer notifications., which is a pity!

Thank you,
Michele

template
incidentstatuspage
incidentemail

@labolanimichele
Copy link
Author

(I had already opened it in #2712, but I still see the same problem)

@jbrooksuk
Copy link
Member

Looks like the emails don't support Markdown.

@jbrooksuk jbrooksuk added the Bug Bugs with Cachet label Mar 13, 2018
@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Mar 13, 2018
@nalysius
Copy link
Contributor

nalysius commented Mar 14, 2018

I read the Laravel documentation and I saw that the message had a markdown method. Perhaps we could use it in app/Notifications/**/*Notification.php instead of line?

@jbrooksuk jbrooksuk added up-for-grabs Good First Issue If you're looking for a good issue to PR, start here labels Mar 17, 2018
@jbrooksuk jbrooksuk self-assigned this Mar 17, 2018
@jbrooksuk
Copy link
Member

This should be fixed now.

@uxen-ab
Copy link
Contributor

uxen-ab commented Mar 28, 2018

@jbrooksuk I think this issue can be reopened, d63b9b2 seems don't fix it.
This issue was fixed, but by removing the line markdown in 0c96e67 the markdown is no longer interpreted and all the text is on one line, as pointed on Slack by sontt.

@jbrooksuk
Copy link
Member

@jbrooksuk I think this issue can be reopened, d63b9b2 seems don't fix it.

@uxen-ab what do you mean it's not fixed, sorry? We should be stripping out all HTML/Markdown.

@uxen-ab
Copy link
Contributor

uxen-ab commented Mar 31, 2018

@jbrooksuk I have not experienced this issue, it's sontt, on Slack, that reported it to me, with screenshots. During the week on Slack I'll ask him to explain more here.
He sent me a screenshot where its email was in this issue, markdown not interpreted and line breaks either.

@sontt710
Copy link

sontt710 commented Apr 2, 2018

Hi,

I created an incident to notification via email, but in an email no new line break, but dashboard work fine.

image
image

@jbrooksuk
Copy link
Member

This will be fixed in #3100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bugs with Cachet Good First Issue If you're looking for a good issue to PR, start here
Projects
None yet
Development

No branches or pull requests

5 participants