Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two-factor auth flow should ignore spaces in token #2405

Closed
wolfgang42 opened this issue Mar 5, 2017 · 2 comments
Closed

Two-factor auth flow should ignore spaces in token #2405

wolfgang42 opened this issue Mar 5, 2017 · 2 comments
Labels
Bug Bugs with Cachet
Milestone

Comments

@wolfgang42
Copy link

I enabled two-factor auth and then panicked because I couldn't log in any more. This turned out to be because the Google Authenticator app displays the code in two halves, like 123 456, but the authentication code is expecting the digits all together, like 123456. The auth flow should probably strip the spaces from this field before checking it, so that both ways work as expected.

@jbrooksuk jbrooksuk added the Bug Bugs with Cachet label Mar 5, 2017
@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Mar 5, 2017
@jbrooksuk
Copy link
Member

Nice observation!

@jbrooksuk
Copy link
Member

Fixed in 2742797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bugs with Cachet
Projects
None yet
Development

No branches or pull requests

2 participants