Updated types to support calling ObjectID() without the new keyword
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds type tests for calling ObjectID without new
We use interfaces here to allow us to define an object as both "newable" and callable. We have one interface for the class constructor, this defines how to call it (new & as a function) as well as the static methods. We then have another interface for the instance, this defines the members and methods. We then have to export a const ObjectID so that typescript knows we are dealing with values, rather than types. ref https://discord.com/channels/508357248330760243/765583369345302570/879753593320796230
closes cabinjs#38 Since 2.0.0 the `generate` method has been removed from the ObjectID class, this updates the types to reflect that. refs cabinjs@a518e352
|
Released in v2.0.2 to npm https://github.com/williamkapke/bson-objectid/releases/tag/v2.0.2 |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the typescript definitions file to allow calling the
ObjectIDclass withoutnew- as documented in the README and testsWe use interfaces here to allow us to define an object as both "newable" and callable.
We have one interface for the class constructor, this defines how to call it (new & as a function) as well as the static methods.
We then have another interface for the instance, this defines the members and methods.
We then have to export a
const ObjectIDso that typescript knows we are dealing with values, rather than types.