Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with BSON 1.x #37

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Mar 1, 2021

This makes this package compatible with version 1.x of the BSON package, the one currently used by the official MongoDB package.

  • It removes setMachineID/getMachineID which isn't present in the BSON package
  • It moves ObjectID.generate to ObjectID.prototype.generate, and changes it to return 12-byte string
  • id is now stored as a normal property (which allows clone to work 🙌)
  • _bsontype is stored directly on the object instead of in the prototype (just to match BSON)
  • probable some other minor changes 😅

@LinusU
Copy link
Contributor Author

LinusU commented Mar 1, 2021

This should probably be released as a major version btw, since it makes some breaking changes.

Also, if you need help maintaining this package I would be happy to jump on!

(also ping @niftylettuce since you seem to be the last person cutting a release ☺️)

@niftylettuce niftylettuce merged commit a518e35 into cabinjs:master Mar 1, 2021
@niftylettuce
Copy link
Collaborator

v2.0.0 released

@williamkapke
Copy link
Collaborator

Thanks for this!

Thanks again @niftylettuce for handling it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants