Use is-buffer module to check for buffers, avoiding browserify bloat #3

andyburke · 2015-03-05T03:33:41Z

No description provided.

If we check for Buffer at runtime, browserify won't pull in its core buffer implementation, saving ~40K or so.

Check Buffer at runtime to avoid browserify shims

…oat.

williamkapke · 2015-03-06T20:22:22Z

Hmm.. yes I want to avoid this- however I don't want to introduce a sub-dependency (it's a legal thing for many)

The guts of is-buffer is tiny so I'd like to just add it directly with attribution to @feross for his work.

@feross, if you object- please let me know and I'll consider other options.

feross · 2015-03-06T21:28:10Z

@williamkapke The code is MIT licensed, so there shouldn't be any legal issues with using the module directly. But I don't mind the way you've used it directly either :)

andyburke added 3 commits March 4, 2015 19:10

Check Buffer at runtime to avoid browserify shims

52489c8

If we check for Buffer at runtime, browserify won't pull in its core buffer implementation, saving ~40K or so.

Merge pull request #1 from andyburke/revision/check_buffer_at_runtime

638205f

Check Buffer at runtime to avoid browserify shims

Use the is-buffer module to check for buffers and avoid browserify bl…

b304d92

…oat.

williamkapke closed this in 40a70bc Mar 6, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use is-buffer module to check for buffers, avoiding browserify bloat #3

Use is-buffer module to check for buffers, avoiding browserify bloat #3

andyburke commented Mar 5, 2015

williamkapke commented Mar 6, 2015

feross commented Mar 6, 2015

Use is-buffer module to check for buffers, avoiding browserify bloat #3

Use is-buffer module to check for buffers, avoiding browserify bloat #3

Conversation

andyburke commented Mar 5, 2015

williamkapke commented Mar 6, 2015

feross commented Mar 6, 2015