Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types and fix minor bug #16

Merged
merged 2 commits into from
Apr 23, 2024
Merged

feat: add types and fix minor bug #16

merged 2 commits into from
Apr 23, 2024

Conversation

shadowgate15
Copy link
Contributor

First and foremost this adds TypeScript types.

Second, I noticed a minor bug in making sure that all necessary methods on the logger was set to functions. If a logger was passed in with a field of 'log', for example, that was set to a non-nullish value but was not a function, Axe could attempt to set another required field to that value. This causes errors when that function is needed.

Checklist

  • [ x ] I have ensured my pull request is not behind the main or master branch of the original repository.
  • [ x ] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • [ x ] I have written a commit message that passes commitlint linting.
  • [ x ] I have ensured that my code changes pass linting tests.
  • [ x ] I have ensured that my code changes pass unit tests.
  • [ x ] I have described my pull request and the reasons for code changes along with context if necessary.

@shadowgate15
Copy link
Contributor Author

@titanism it looks like xo version 0.57.0 bumped to require node 18. How would you like to proceed?

@titanism
Copy link
Contributor

I will require node v18 and major bump

@titanism titanism merged commit 927ea2c into master Apr 23, 2024
3 of 9 checks passed
@titanism titanism deleted the types/init branch April 23, 2024 18:46
@titanism
Copy link
Contributor

Actually, just will stick to v0.56 for now.

@titanism
Copy link
Contributor

I think we need to add to files the types

@titanism
Copy link
Contributor

done 1879384

@titanism
Copy link
Contributor

v12.2.4 released, thanks @shadowgate15 🙏 🚀

https://github.com/cabinjs/axe/releases/tag/v12.2.4

also I dropped node v14 and node v16 from CI tests in workflow CI yml file - thanks for that tip @shadowgate15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants