Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support traversing non-defined type fields #96

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

danielkrainas
Copy link
Contributor

Adds support for traversing non-defined type fields

type T struct {
  NonDefinedField struct {
    Foo string `env:"T_FOO"`
  }
}

@ghost
Copy link

ghost commented Sep 14, 2019

There were the following issues with this Pull Request

  • Commit: 9d07610
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@codecov
Copy link

codecov bot commented Sep 14, 2019

Codecov Report

Merging #96 into master will decrease coverage by 0.87%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage     100%   99.12%   -0.88%     
==========================================
  Files           1        1              
  Lines         223      228       +5     
==========================================
+ Hits          223      226       +3     
- Misses          0        1       +1     
- Partials        0        1       +1
Impacted Files Coverage Δ
env.go 99.12% <100%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f394d0b...9512dc7. Read the comment docs.

@caarlos0
Copy link
Owner

hey, thanks for the PR!

mind to add tests as well?

@caarlos0 caarlos0 changed the title support traversing non-defined type fields feat: support traversing non-defined type fields Sep 14, 2019
@ghost
Copy link

ghost commented Sep 17, 2019

There were the following issues with this Pull Request

  • Commit: 9512dc7
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@caarlos0 caarlos0 merged commit c67acb9 into caarlos0:master Sep 17, 2019
@caarlos0
Copy link
Owner

Thanks!

nexoscp added a commit to nexoscp/env that referenced this pull request Apr 7, 2022
* feat: support traversing non-defined type fields

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants