feat(parsing): Added encoding.TextUnmarshaler support #53
Conversation
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
env.go
Outdated
| @@ -122,7 +123,7 @@ func get(field reflect.StructField) (string, error) { | |||
| case "required": | |||
| val, err = getRequired(key) | |||
| default: | |||
| err = errors.New("Env tag option " + opt + " not supported.") | |||
| err = fmt.Errorf("Env tag option %q not supported.", opt) | |||
There was a problem hiding this comment.
error strings should not be capitalized or end with punctuation or a newline
There was a problem hiding this comment.
Agreed, but I didn't add them and they are all through the code so didn't want to pollute the functionality of this commit with those changes.
stevenh
force-pushed
the
text-unmarshaler
branch
from
036d649 to
d1af6f5
Compare
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Support arbitrary types by adding the ability to deserialize environment variables on any type that implements encoding.TextUnmarshaler. This avoids the overhead of having to write custom parser funcs. Also: * Eliminate duplicate handleStruct method. * Use fmt.Errorf instead of errors.New with concatenated strings.
stevenh
force-pushed
the
text-unmarshaler
branch
from
d1af6f5 to
c4f2804
Compare
stevenh
changed the title
|
that's super nice! Thanks @stevenh! |
feat(parsing): Added encoding.TextUnmarshaler support
Support arbitrary types by adding the ability to deserialize environment variables on any type that implements encoding.TextUnmarshaler.
This avoids the overhead of having to write custom parser funcs.
Also: