Fix uint64 alias custom parser

[vith]

Needed to check for custom parsers before matching against basic types, since aliases of those types were matching in the switch, causing the custom parser to be ignored.

[ghost]

There were the following issues with this Pull Request

• Commit: f1eaf06
  • ✖ message may not be empty
    , - ✖ type may not be empty
• Commit: 9f04fdc
  • ✖ message may not be empty
    , - ✖ type may not be empty
• Commit: 0e21b77
  • ✖ message may not be empty
    , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

---

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

[coveralls]

Coverage increased (+0.004%) to 98.754% when pulling 299995a on vith:fix-uint64-alias-custom-parser into bc122c2 on caarlos0:master.

[vith]

The last commit I added, "remove redundant struct handling", was done because code coverage had shown only the error path of handleStruct was being reached now, so code coverage had been reduced.

There is a slight difference now, in that the custom parser for structs is looked up with funcMap[refType.Type] instead of funcMap[field.Type()]. All tests are still passing, but it is not clear to me whether these would always be identical. Is there another scenario I should add a test for where this would matter?

[caarlos0]

Hi @vith ,

Sorry for the delay.

Can you rebase the work? It looks good :)

[vith]

Sorry for the delay here too. It's rebased now. The CI failure looks like network flakiness I think? Maybe you can trigger a retry.

[caarlos0]

thanks for the PR @vith !