Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The expand logic for env tag options has been modified, and the customOptions function has been refactored #349

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

astak16
Copy link
Contributor

@astak16 astak16 commented Dec 7, 2024

  1. If the environment variable key specified in env does not exist in the environment variables, and the key specified in envDefault is in the format of "${var}" or "$var", after being read, it is not replaced with the desired value.
  2. the merging of customOptions and options has been written as the mergeOptions function.

I’m not sure if you accept these two commits.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (52e7186) to head (8f2e342).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #349   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          625       618    -7     
=========================================
- Hits           625       618    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 9, 2024
@astak16
Copy link
Contributor Author

astak16 commented Dec 9, 2024

Sorry, the two "fix: typo" commits were because I forgot to run the test cases.

@caarlos0 caarlos0 merged commit 6f3a5c0 into caarlos0:main Dec 12, 2024
17 checks passed
@caarlos0
Copy link
Owner

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants