Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cleanup readme #322

Merged
merged 3 commits into from
Aug 7, 2024
Merged

docs: cleanup readme #322

merged 3 commits into from
Aug 7, 2024

Conversation

caarlos0
Copy link
Owner

@caarlos0 caarlos0 commented Aug 7, 2024

I moved all the examples to example_test.go - which should show up in pkg.go.dev.

Some examples in the readme were incorrect, some features were not documented, that kind of thing.

This way we have testable examples... hopefully that's better? wdyt?

Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0
Copy link
Owner Author

caarlos0 commented Aug 7, 2024

examples are already on main, but still not showing up in pkg.go.dev

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1282042) to head (73b4b45).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #322   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          498       498           
=========================================
  Hits           498       498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0 caarlos0 merged commit fac6114 into main Aug 7, 2024
14 checks passed
@caarlos0 caarlos0 deleted the readme branch August 7, 2024 12:46
BorzdeG pushed a commit to BorzdeG/env that referenced this pull request Aug 24, 2024
* docs: cleanup readme

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* docs: more improvements

---------

Signed-off-by: Carlos Alexandro Becker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant