Add GetFieldParams and GetFieldParamsWithOptions functions #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caarlos0 Any problems with this concept? |
|
Implementation looks OK, but needs merge with main. |
|
Done |
caarlos0
reviewed
Jul 24, 2023
| } | ||
|
|
||
| func parseInternal(v interface{}, opts Options) error { | ||
| func GetFieldParams(v interface{}) ([]FieldParams, error) { |
| return GetFieldParamsWithOptions(v, defaultOptions()) | ||
| } | ||
|
|
||
| func GetFieldParamsWithOptions(v interface{}, opts Options) ([]FieldParams, error) { |
| var unset bool | ||
| var notEmpty bool | ||
| var expand bool | ||
| type FieldParams struct { |
|
hey, just missing the godocs and pass thank you |
|
@caarlos0 No problem, I've made the corrections you suggested. |
|
merged, thank you! |
BorzdeG
pushed a commit
to BorzdeG/env
that referenced
this pull request
Aug 24, 2024
…0#261) * Add GetFieldParams and GetFieldParamsWithOptions functions * Add nested structure to tests * Fixes after merge with origin/main * Added missing godocs and fixed golangci-lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's example implementation for #260, not really sure about names I used :)