Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource-data-all endpoint and MyBatis SQL methods #11051

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Add resource-data-all endpoint and MyBatis SQL methods #11051

merged 3 commits into from
Oct 28, 2024

Conversation

hweej
Copy link
Contributor

@hweej hweej commented Oct 7, 2024 •
edited by inodb
Loading

Implement backend changes for #11004

  • Adds new resource-data-all endpoint which returns all resource-data for all patients and all samples within a study.
  • Adds two new SELECT statements in mybatis layer.

@hweej hweej self-assigned this Oct 7, 2024
onursumer
onursumer approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inodb inodb added api and removed in progress labels Oct 28, 2024
@inodb inodb merged commit 8e1a02b into cBioPortal:master Oct 28, 2024
11 of 15 checks passed
This was referenced Oct 28, 2024
Open
Merged
dippindots added a commit that referenced this pull request Oct 31, 2024
@dippindots
Revert "Merge pull request #11051 from hweej/11004/resource-data-expa…
f056bc4 
…nd-all-results"

This reverts commit 8e1a02b, reversing
changes made to 2284f83.
inodb pushed a commit to cBioPortal/cbioportal-frontend that referenced this pull request Nov 1, 2024
@hweej
On Study View handle larger number of resource files (#5034)
9a02d70 
Fixes cBioPortal/cbioportal#11004 (associated backend PR is merged, see cBioPortal/cbioportal#11051). This PR modifies the FilesAndLinks table on the Study View to use the new resource-data-all endpoint, which reduces the number of API requests and enables showing thousands of resource files without performance degradation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onursumer onursumer onursumer approved these changes

@haynescd haynescd Awaiting requested review from haynescd

Assignees

@hweej hweej

Labels
api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hweej @onursumer @inodb