-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed outdated keycloak docker image #10908
Fixed outdated keycloak docker image #10908
Conversation
Changed the Docker Image from jboss image to the actual keycloak image since jboss image is not maintained anymore
Thanks so much for this fix @ugurkoysuren ! One issue is that the docs will also need to be updated to be in sync: https://github.com/cBioPortal/cbioportal/blob/master/docs/deployment/authorization-and-authentication/Authenticating-and-Authorizing-Users-via-keycloak.md. Is this something you could help with? |
This additionally changes keycloak from version 4 to version 25. This is a huge increment. Did you confirm this much newer version of keycloak works? |
I tested it with the same version and changin the provider, it is currently working, needed to change the path as well. Can someone review the PR and test it? @inodb @gl00ten cBioPortal/cbioportal-docker-compose#25 If it's working with the quay image we could also merge this PR with the same Quay Image. I will also correct the Documentation after the image PR's getting Merged! @inodb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ugurkoysuren Thanks so much for fixing this! I didn't get a chance to test it, but it anyway seems better than the current situation with a non-existent image
If you're able to provide another PR with updated keycloak documentation that would be super helpful!
Changed the Docker Image from jboss image to the actual keycloak image since jboss image is not maintained anymore
Describe changes proposed in this pull request: