Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed outdated keycloak docker image #10908

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

ugurkoysuren
Copy link
Contributor

@ugurkoysuren ugurkoysuren commented Jul 25, 2024

Changed the Docker Image from jboss image to the actual keycloak image since jboss image is not maintained anymore

Describe changes proposed in this pull request:

  • Changed the Docker Image from jboss image to the actual keycloak image since jboss image is not maintained anymore

Changed the Docker Image from jboss image to the actual keycloak image since jboss image is not maintained anymore
@inodb inodb added the bug label Aug 7, 2024
@inodb inodb requested review from hweej and haynescd August 7, 2024 15:10
@inodb
Copy link
Member

inodb commented Aug 7, 2024

Thanks so much for this fix @ugurkoysuren !

One issue is that the docs will also need to be updated to be in sync: https://github.com/cBioPortal/cbioportal/blob/master/docs/deployment/authorization-and-authentication/Authenticating-and-Authorizing-Users-via-keycloak.md. Is this something you could help with?

@gl00ten
Copy link

gl00ten commented Aug 14, 2024

This additionally changes keycloak from version 4 to version 25. This is a huge increment. Did you confirm this much newer version of keycloak works?
I wasn't able to make the cbioportal installation work with keycloak versions 8,9,10 and 25.
Someone else confirm before merging this.

@inodb
Copy link
Member

inodb commented Aug 14, 2024

Thanks @gl00ten ! @hweej tried v25 and ran into some issues that will require some code changes in the cBioPortal backend

@ugurkoysuren
Copy link
Contributor Author

ugurkoysuren commented Aug 14, 2024

Good Point, but what is the temporary solution right now? The Jboss image cannot be pulled anymore @gl00ten @inodb

@ugurkoysuren
Copy link
Contributor Author

ugurkoysuren commented Aug 15, 2024

I tested it with the same version and changin the provider, it is currently working, needed to change the path as well.

Can someone review the PR and test it? @inodb @gl00ten

cBioPortal/cbioportal-docker-compose#25

If it's working with the quay image we could also merge this PR with the same Quay Image. I will also correct the Documentation after the image PR's getting Merged! @inodb

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ugurkoysuren Thanks so much for fixing this! I didn't get a chance to test it, but it anyway seems better than the current situation with a non-existent image

If you're able to provide another PR with updated keycloak documentation that would be super helpful!

@inodb inodb merged commit 229c01f into cBioPortal:master Aug 27, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants