Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQ for Upcoming GDC Data Release #10894

Merged
merged 16 commits into from
Aug 1, 2024
Merged

Update FAQ for Upcoming GDC Data Release #10894

merged 16 commits into from
Aug 1, 2024

Conversation

jamesqo
Copy link
Contributor

@jamesqo jamesqo commented Jul 16, 2024

Updates the cBioPortal FAQ to address the points in knowledgesystems/pipelines-scrum#1352, including:

  • Genome Build (Hg38?)
  • ASCAT vs GISTIC Copy Number
  • How GDC data differs from PanCan
  • Used mutation callers, it it union or some? [not sure what is meant by this?]
  • GDC Data availability/difference from existing cBioPortal data

Checks

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

/cc @inodb @tmazor @schultzn @averyniceday @ritikakundra @n1zea144

Copy link
Contributor

@n1zea144 n1zea144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to have a discussion about the content in the TCGA section.

docs/user-guide/faq.md Outdated Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few comments

Copy link
Contributor

@tmazor tmazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - just one main suggestion to combine two Qs into a single 'what are all these different TCGA studies?' type question.

docs/user-guide/faq.md Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
docs/user-guide/faq.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 27, 2024

@inodb inodb merged commit c7d341b into master Aug 1, 2024
18 of 19 checks passed
@inodb inodb deleted the update-faq branch August 1, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants