Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor code: RAS/RAF alterations in colorectal c… #4907

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SAHU-01
Copy link
Contributor

@SAHU-01 SAHU-01 commented May 8, 2024

Fix cBioPortal/cbioportal#10780(see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • To maintain the gene structure in case of an OQL query deletion, a condition was set, if the deleted gene track has a sublabel after it's deletion a new line must be added to the existing genes. But when no sublabel is present a default sublabel for '' always gets assigned in application. For the first time when remove track was clicked in RAS/RAF, it added a new line[following oql query logic because '' is also a sublabel] , and on second removal I removed the gene. To fix this issue this condition which always in the presence of a sublabel adds a new line first has to be modified
  • To modify the condition, in case of oql queries, specially in the query params of genelist '%20' is present, on adding this check alongside if a sublabel is present, the new line addition logic now works only for oql queries, and the other remove tracks not affected.

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

@onursumer
Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

…ancer, can't remove gene track in first attempt
Copy link

netlify bot commented May 8, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 522e111
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/66710b530406550008e58363
😎 Deploy Preview https://deploy-preview-4907--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Looks like we still need to fix the issue with OQL. See cBioPortal/cbioportal#10780 (comment) for details

@SAHU-01 SAHU-01 requested a review from onursumer June 18, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove track doesn't work on first try when coming from homepage
2 participants