Customizable Dynamic Kaplan-Meier Plot for Survival Analysis #4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7xuanlu
force-pushed
the
fix-10375
branch
2 times, most recently
from
00258c8
to
51e2fef
Compare
7xuanlu
force-pushed
the
fix-10375
branch
2 times, most recently
from
afa3564
to
c4e675c
Compare
7xuanlu
force-pushed
the
fix-10375
branch
3 times, most recently
from
ca52e19
to
350f297
Compare
alisman
reviewed
Oct 9, 2024
There was a problem hiding this comment.
we shouldn't need package lock. use yarn to add new things, not npm
alisman
reviewed
Oct 9, 2024
| @@ -75,7 +76,13 @@ export default class GroupComparisonPage extends React.Component< | |||
| this.pathwayMapperUserSelectionStore = new GroupComparisonPathwayMapperUserSelectionStore(); | |||
| this.queryReaction = reaction( | |||
| () => this.urlWrapper.query.comparisonId, | |||
| sessionId => { | |||
| (sessionId, previousSessionId) => { | |||
| if (localStorage.getItem('preventPageReload') === 'true') { | |||
alisman
reviewed
Oct 9, 2024
|
|
||
| const survivalPrefixes = _.map( | ||
| this.props.store.survivalTitleByPrefix | ||
| .result! as Dictionary<string>, |
There was a problem hiding this comment.
shouldn't need cast if type properly
alisman
reviewed
Oct 9, 2024
| } | ||
|
|
||
| @observable | ||
| public startEventPosition: 'FIRST' | 'LAST' = 'FIRST'; |
There was a problem hiding this comment.
i think this needs to be someone scoped better. i.e. it needs to be somehow associated with the survival plot stuff, not just hanging out here in top level of store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue Dynamic KM Plot and RFC 36
This frontend PR aims to have a customizable Dynamic Kaplan-Meier plot that allows users to specify start point and endpoint or censored point for survival analysis.