Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add aggTrade for binance #994

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

zenixls2
Copy link
Collaborator

add new websocket subscription: @aggTrade.
this will aggregate trades with the same price as one.

@zenixls2 zenixls2 requested review from c9s and austin362667 October 17, 2022 08:02
@bbgokarma-bot
Copy link

Welcome back! @zenixls2, This pull request may get 340 BBG.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #994 (9213caf) into main (763bb45) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
- Coverage   19.91%   19.88%   -0.03%     
==========================================
  Files         420      420              
  Lines       31922    31960      +38     
==========================================
  Hits         6356     6356              
- Misses      24960    24998      +38     
  Partials      606      606              
Impacted Files Coverage Δ
pkg/exchange/binance/convert.go 5.19% <0.00%> (-0.14%) ⬇️
pkg/exchange/binance/parse.go 21.84% <0.00%> (-2.23%) ⬇️
pkg/exchange/binance/stream.go 0.00% <0.00%> (ø)
pkg/exchange/binance/stream_callbacks.go 0.00% <0.00%> (ø)
pkg/types/standardstream_callbacks.go 0.00% <0.00%> (ø)
pkg/types/stream.go 0.00% <ø> (ø)
pkg/bbgo/order_executor_general.go 17.16% <0.00%> (+0.05%) ⬆️
pkg/bbgo/activeorderbook.go 3.97% <0.00%> (+0.21%) ⬆️
pkg/bbgo/risk.go 35.65% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 763bb45...9213caf. Read the comment docs.

@zenixls2 zenixls2 merged commit 6f0c4fd into c9s:main Oct 17, 2022
@bbgokarma-bot
Copy link

Hi @zenixls2,

Well done! 350 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x43f40e227f63ccfadc38e7c1295b4245d46bf64feb914c97c321ce03b389cb26

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants