Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strategy: add harmonic shark pattern recognition #976

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

austin362667
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @austin362667, This pull request may get 999 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 924 BBG

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #976 (22ef28b) into main (04453c2) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #976   +/-   ##
=======================================
  Coverage   19.91%   19.92%           
=======================================
  Files         420      420           
  Lines       31881    31883    +2     
=======================================
+ Hits         6350     6353    +3     
+ Misses      24927    24925    -2     
- Partials      604      605    +1     
Impacted Files Coverage Δ
pkg/bbgo/persistence.go 66.66% <0.00%> (-3.34%) ⬇️
pkg/bbgo/isolation.go 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04453c2...22ef28b. Read the comment docs.


beta float64

StopLoss fixedpoint.Value `json:"stoploss"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used ?

PredictOffset int `json:"predictOffset"`
HighLowVarianceMultiplier float64 `json:"hlVarianceMultiplier"`
NoTrailingStopLoss bool `json:"noTrailingStopLoss"`
TrailingStopLossType string `json:"trailingStopLossType"` // trailing stop sources. Possible options are `kline` for 1m kline and `realtime` from order updates
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used?

StopLoss fixedpoint.Value `json:"stoploss"`
CanvasPath string `json:"canvasPath"`
PredictOffset int `json:"predictOffset"`
HighLowVarianceMultiplier float64 `json:"hlVarianceMultiplier"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used?

@austin362667 austin362667 force-pushed the austin362667/harmonic branch from ea97601 to 006575a Compare October 3, 2022 17:44
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 889 BBG

log.WithError(err).Errorf("open pnl")
return
}
defer f.Close()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the f here is in defer, and f will be overridden.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 1031 BBG

@austin362667 austin362667 force-pushed the austin362667/harmonic branch from 4dfa81a to ec60c70 Compare October 4, 2022 07:23
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 1036 BBG

if err != nil {
return fmt.Errorf("cannot create on path " + s.GraphCumPNLPath)
}
defer f.Close()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the f here can be overridden

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 1051 BBG

@c9s c9s merged commit 4d42a61 into c9s:main Oct 4, 2022
@bbgokarma-bot
Copy link

Hi @austin362667,

Well done! 1056 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xbefa45be9fd6c429e3440a437c31ca1c267e793a9e7e45eddd4a337070a9d371

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants