-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strategy: add harmonic shark pattern recognition #976
Conversation
Welcome back! @austin362667, This pull request may get 999 BBG. |
292dfed
to
ea97601
Compare
Re-estimated karma: this pull request may get 924 BBG |
Codecov Report
@@ Coverage Diff @@
## main #976 +/- ##
=======================================
Coverage 19.91% 19.92%
=======================================
Files 420 420
Lines 31881 31883 +2
=======================================
+ Hits 6350 6353 +3
+ Misses 24927 24925 -2
- Partials 604 605 +1
Continue to review full report at Codecov.
|
pkg/strategy/harmonic/strategy.go
Outdated
|
||
beta float64 | ||
|
||
StopLoss fixedpoint.Value `json:"stoploss"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used ?
pkg/strategy/harmonic/strategy.go
Outdated
PredictOffset int `json:"predictOffset"` | ||
HighLowVarianceMultiplier float64 `json:"hlVarianceMultiplier"` | ||
NoTrailingStopLoss bool `json:"noTrailingStopLoss"` | ||
TrailingStopLossType string `json:"trailingStopLossType"` // trailing stop sources. Possible options are `kline` for 1m kline and `realtime` from order updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used?
pkg/strategy/harmonic/strategy.go
Outdated
StopLoss fixedpoint.Value `json:"stoploss"` | ||
CanvasPath string `json:"canvasPath"` | ||
PredictOffset int `json:"predictOffset"` | ||
HighLowVarianceMultiplier float64 `json:"hlVarianceMultiplier"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used?
ea97601
to
006575a
Compare
Re-estimated karma: this pull request may get 889 BBG |
pkg/strategy/harmonic/strategy.go
Outdated
log.WithError(err).Errorf("open pnl") | ||
return | ||
} | ||
defer f.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the f here is in defer, and f will be overridden.
Re-estimated karma: this pull request may get 1031 BBG |
strategy: add harmonic shark pattern recognition
4dfa81a
to
ec60c70
Compare
Re-estimated karma: this pull request may get 1036 BBG |
pkg/strategy/harmonic/draw.go
Outdated
if err != nil { | ||
return fmt.Errorf("cannot create on path " + s.GraphCumPNLPath) | ||
} | ||
defer f.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the f here can be overridden
Re-estimated karma: this pull request may get 1051 BBG |
Hi @austin362667, Well done! 1056 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0xbefa45be9fd6c429e3440a437c31ca1c267e793a9e7e45eddd4a337070a9d371 Thank you for your contribution! |
No description provided.