Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types/tradeStats: use last order id to identity consecutive win and loss #922

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

c9s
Copy link
Owner

@c9s c9s commented Sep 8, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #922 (3aebb58) into main (56c5395) will increase coverage by 0.11%.
The diff coverage is 54.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
+ Coverage   19.93%   20.04%   +0.11%     
==========================================
  Files         407      410       +3     
  Lines       30165    30450     +285     
==========================================
+ Hits         6013     6104      +91     
- Misses      23574    23760     +186     
- Partials      578      586       +8     
Impacted Files Coverage Δ
pkg/types/trade_stats.go 19.10% <54.16%> (+19.10%) ⬆️
pkg/bbgo/order_executor_general.go 26.95% <0.00%> (-2.86%) ⬇️
pkg/bbgo/activeorderbook.go 3.76% <0.00%> (-1.71%) ⬇️
pkg/bbgo/session.go 7.42% <0.00%> (-0.30%) ⬇️
pkg/types/kline.go 4.97% <0.00%> (-0.16%) ⬇️
pkg/dynamic/print_config.go 0.00% <0.00%> (ø)
pkg/bbgo/source.go 40.81% <0.00%> (ø)
pkg/types/pca.go 0.00% <0.00%> (ø)
pkg/bbgo/serialmarketdatastore.go 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c5395...3aebb58. Read the comment docs.

@c9s c9s merged commit 1c7b40a into main Sep 8, 2022
@c9s c9s deleted the fix/trade-stats-for-live branch September 8, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants