fix: strategy/pivotshort: add trade loss to the account value calculation #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back! @c9s, This pull request may get 208 BBG. |
|
Re-estimated karma: this pull request may get 213 BBG |
Codecov Report
@@ Coverage Diff @@
## main #834 +/- ##
==========================================
- Coverage 19.78% 19.77% -0.01%
==========================================
Files 365 365
Lines 27846 27849 +3
==========================================
Hits 5508 5508
- Misses 21812 21815 +3
Partials 526 526
Continue to review full report at Codecov.
|
|
Hi @c9s, Well done! 223 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0xb3b732fc27441363542389e437b3b716720ac900b99de5d184d6f2155d5184ef Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.