Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strategy/pivotshort: fix margin quantity calculation #833

Merged
merged 6 commits into from
Jul 21, 2022

Conversation

c9s
Copy link
Owner

@c9s c9s commented Jul 21, 2022

No description provided.

@c9s c9s requested review from andycheng123 and austin362667 July 21, 2022 04:48
@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 281 BBG.

@c9s c9s requested a review from narumiruna July 21, 2022 04:49
@c9s c9s enabled auto-merge July 21, 2022 04:49
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #833 (763ae1f) into main (0a08cc2) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   19.81%   19.78%   -0.04%     
==========================================
  Files         365      365              
  Lines       27801    27846      +45     
==========================================
  Hits         5508     5508              
- Misses      21767    21812      +45     
  Partials      526      526              
Impacted Files Coverage Δ
pkg/bbgo/session.go 7.81% <0.00%> (-0.21%) ⬇️
pkg/bbgo/trader.go 0.00% <0.00%> (ø)
pkg/strategy/pivotshort/breaklow.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a08cc2...763ae1f. Read the comment docs.

@c9s c9s merged commit 8c61f68 into main Jul 21, 2022
@c9s c9s deleted the fix/pivotshort-quantity-cal branch July 21, 2022 04:58
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 291 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x4c195d10f16650447d4d662ee54d4bf2914d7cadb0deb3a502c39b04c9a23561

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants