Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizer: eliminate limitation of number of grid point #829

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

COLDTURNIP
Copy link
Collaborator

Currently we queue the backtest tasks in a buffered channel, and enqueue all the tasks before execution. This will cause deadlock if the number of grid points more than 10,000. In this PR, it generate tasks asynchronously on another goroutine, hence the deadlock won't happen.

This PR replaces #828

@bbgokarma-bot
Copy link

Welcome back! @COLDTURNIP, This pull request may get 212 BBG.

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #829 (620381f) into main (44f3793) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
- Coverage   19.86%   19.85%   -0.01%     
==========================================
  Files         364      364              
  Lines       27712    27719       +7     
==========================================
  Hits         5504     5504              
- Misses      21683    21690       +7     
  Partials      525      525              
Impacted Files Coverage Δ
pkg/optimizer/grid.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f3793...620381f. Read the comment docs.

Copy link
Owner

@c9s c9s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@c9s c9s merged commit a116307 into c9s:main Jul 15, 2022
@bbgokarma-bot
Copy link

Hi @COLDTURNIP,

Well done! 222 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x6f5aca7e70b29eb5669c344aa87935ef247e3742f283fc85c6121ec0c50c13ee

Thank you for your contribution!

@COLDTURNIP COLDTURNIP deleted the feature/eliminate_grid_limit branch July 31, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants