Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor bollinger band indicator with the new series extend component #823

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

c9s
Copy link
Owner

@c9s c9s commented Jul 14, 2022

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 337 BBG.

@c9s c9s force-pushed the refactor/indicator-api branch from 55f927b to 2ef8ecf Compare July 14, 2022 06:26
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 362 BBG

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #823 (2ef8ecf) into main (975d0d6) will decrease coverage by 0.01%.
The diff coverage is 38.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   19.93%   19.91%   -0.02%     
==========================================
  Files         362      364       +2     
  Lines       27631    27665      +34     
==========================================
+ Hits         5507     5509       +2     
- Misses      21591    21629      +38     
+ Partials      533      527       -6     
Impacted Files Coverage Δ
pkg/indicator/stddev_callbacks.go 0.00% <0.00%> (ø)
pkg/strategy/bollmaker/strategy.go 2.94% <0.00%> (ø)
pkg/strategy/bollmaker/trend.go 0.00% <0.00%> (ø)
pkg/strategy/xmaker/strategy.go 2.67% <0.00%> (ø)
pkg/indicator/stddev.go 25.58% <25.58%> (ø)
pkg/indicator/boll.go 46.77% <75.86%> (+3.91%) ⬆️
pkg/indicator/sma.go 50.00% <0.00%> (-8.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975d0d6...2ef8ecf. Read the comment docs.

@c9s c9s merged commit 3651b84 into main Jul 14, 2022
@c9s c9s deleted the refactor/indicator-api branch July 14, 2022 07:12
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 372 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x4dabe200d07af646344908a657f24047098e6b8f0170e0b0895e4412a60c6ee5

Thank you for your contribution!

@c9s c9s restored the refactor/indicator-api branch July 14, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants