Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor indicator api (canonicalize CalculateAndUpdate, PushK methods) #821

Merged
merged 14 commits into from
Jul 14, 2022

Conversation

c9s
Copy link
Owner

@c9s c9s commented Jul 13, 2022

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 688 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 731 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 741 BBG

@c9s c9s requested a review from andycheng123 July 13, 2022 17:19
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #821 (975d0d6) into main (ce3f7a3) will increase coverage by 0.09%.
The diff coverage is 31.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
+ Coverage   19.83%   19.93%   +0.09%     
==========================================
  Files         362      362              
  Lines       27602    27631      +29     
==========================================
+ Hits         5475     5507      +32     
+ Misses      21597    21591       -6     
- Partials      530      533       +3     
Impacted Files Coverage Δ
pkg/bbgo/session.go 7.77% <0.00%> (ø)
pkg/indicator/ad.go 0.00% <0.00%> (ø)
pkg/indicator/atrp.go 0.00% <0.00%> (ø)
pkg/indicator/cci.go 45.45% <0.00%> (-1.43%) ⬇️
pkg/indicator/cma.go 0.00% <0.00%> (ø)
pkg/indicator/dmi_callbacks.go 16.66% <0.00%> (ø)
pkg/indicator/emv.go 30.18% <0.00%> (-1.19%) ⬇️
pkg/indicator/ewma.go 50.00% <0.00%> (+17.46%) ⬆️
pkg/indicator/ewma_callbacks.go 0.00% <0.00%> (ø)
pkg/indicator/hull_callbacks.go 16.66% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce3f7a3...975d0d6. Read the comment docs.

@c9s c9s force-pushed the refactor/indicator-api branch from 0979487 to 8d8d9a7 Compare July 14, 2022 01:18
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 751 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 792 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 822 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 927 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 938 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 943 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 945 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 951 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 973 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 981 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 985 BBG

@c9s c9s merged commit 58d2384 into main Jul 14, 2022
@c9s c9s deleted the refactor/indicator-api branch July 14, 2022 04:32
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 990 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x1442d9899caf4fb6070b7c3064ca6475ce27eab4c28b182b4b9d5797d1af9c6a

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants