Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: bbgo: call global persistence facade to sync data #755

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

c9s
Copy link
Owner

@c9s c9s commented Jun 21, 2022

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 220 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 238 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 256 BBG

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #755 (c4ac2a2) into main (612df45) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   18.49%   18.48%   -0.01%     
==========================================
  Files         341      341              
  Lines       25776    25782       +6     
==========================================
  Hits         4766     4766              
- Misses      20528    20534       +6     
  Partials      482      482              
Impacted Files Coverage Δ
pkg/bbgo/persistence.go 35.00% <0.00%> (-3.36%) ⬇️
pkg/bbgo/trader.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612df45...c4ac2a2. Read the comment docs.

@c9s c9s merged commit 5b239ad into main Jun 21, 2022
@c9s c9s deleted the improve/persistence-api branch June 21, 2022 07:53
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 266 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xbf9bae8951d8885a1901c1e2eee966411789833b27ea1c3ace5bcda72b7e0518

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants